Button "to" prop to use react router #908
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Button component, the
href
prop causes full page loads. We could wrap each Button (~50 of them) with react-router Link components, or since this project already has react-router, we can add the Link here. That's what this PR proposes.To avoid breaking changes this is done with a new
to
prop, which also mirrors the react-router Link prop. However, it may be possible to re-use thehref
if you were bold enough. Pages outside the purview of the router in use would cause full page loads. I think.Additionally, yarn insisted on updating the lockfile, and I added missing dependencies that I encountered when trying to build locally:@babel/preset-typescript
andwebpack
.Before:
After:
What type of change is this?
Please delete options that are not relevant.
Completeness Checklist
Overview
docs.Playground
.VisualTests
.Quality Checklist:
UI Checklist