Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Box): gap, row-gap, column-gap Box support #857

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Conversation

nathanyoung
Copy link
Contributor

@nathanyoung nathanyoung commented Dec 28, 2023

Adds support to use css gap, row-gap, and column-gap properties in the <Box> component using standard spacing tokens. Applies to only display grid and flex. Childgap remains to support display block.

Screenshot 2023-12-28 at 4 06 48 PM Screenshot 2023-12-28 at 4 07 06 PM

What type of change is this?

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updating documentation.
  • Updating deployment/build pipeline.
  • Updating Project Dependencies
  • Improving or adding to Test Coverage

Completeness Checklist

  • TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
  • DOCS: All new component work is covered in that component's Overview docs.
  • DOCS: All new component work is covered in a component Playground.
  • DOCS: All new visual changes or options are covered under relevant components' VisualTests.
  • My code has no linting or typescript compile warnings.
  • My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

UI Checklist

  • I have conducted visual UAT on my changes/features.
  • My solution works well on desktop, tablet, and mobile browsers.

Copy link

codeclimate bot commented Dec 28, 2023

Code Climate has analyzed commit 0c7ac36 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 97.9%.

View more on Code Climate.

@nathanyoung nathanyoung marked this pull request as ready for review December 29, 2023 00:07
@nathanyoung nathanyoung changed the title [feat] Gap support [feat] gap, row-gap, column-gap Box support Dec 29, 2023
@nathanyoung nathanyoung changed the title [feat] gap, row-gap, column-gap Box support feat(Box): gap, row-gap, column-gap Box support Dec 29, 2023
@nathanyoung nathanyoung merged commit 69b604e into main Jan 2, 2024
11 checks passed
@nathanyoung nathanyoung deleted the feat-gap branch January 2, 2024 18:07
palmettogithub pushed a commit that referenced this pull request Jan 2, 2024
# [0.157.0](v0.156.1...v0.157.0) (2024-01-02)

### Features

* **Box:** gap, row-gap, column-gap Box support ([#857](#857)) ([69b604e](69b604e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant