Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): solar-panels, electric vehicle, heat pump, window #853

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

nathanyoung
Copy link
Contributor

@nathanyoung nathanyoung commented Oct 27, 2023

https://palmetto.atlassian.net/browse/UX-504

adds icons:

  • solar-panels

  • electric vehicle

  • heat pump

  • window

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Updating documentation.

  • Updating deployment/build pipeline.

  • Updating Project Dependencies

  • Improving or adding to Test Coverage

Completeness Checklist

  • TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
  • DOCS: All new component work is covered in that component's Overview docs.
  • DOCS: All new component work is covered in a component Playground.
  • DOCS: All new visual changes or options are covered under relevant components' VisualTests.
  • My code has no linting or typescript compile warnings.
  • My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

UI Checklist

  • I have conducted visual UAT on my changes/features.
  • My solution works well on desktop, tablet, and mobile browsers.

@codeclimate
Copy link

codeclimate bot commented Oct 27, 2023

Code Climate has analyzed commit 26e631d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 97.9%.

View more on Code Climate.

@nathanyoung nathanyoung merged commit f70bf45 into main Oct 27, 2023
8 checks passed
@nathanyoung nathanyoung deleted the ux-504 branch October 27, 2023 20:15
palmettogithub pushed a commit that referenced this pull request Oct 27, 2023
# [0.155.0](v0.154.2...v0.155.0) (2023-10-27)

### Features

* **Icons:** solar-panels, electric vehicle, heat pump, window ([#853](#853)) ([f70bf45](f70bf45))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant