Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix babel 2.14 compatibility #824

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

azmeuk
Copy link
Member

@azmeuk azmeuk commented Jan 5, 2024

Since 2.14 babel does not directly depends on setuptools anymore.

Babel no longer directly depends on either distutils or setuptools; if you had been
using the Babel setuptools command extensions, you would need to explicitly depend on setuptools
though given you're running setup.py you probably already do.

This causes tox -e py312 to fail:

tox -e py312
.pkg: _optional_hooks> python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True hatchling.build
.pkg: get_requires_for_build_sdist> python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True hatchling.build
.pkg: recreate env because dependencies removed: Babel<2.14.0
.pkg: remove tox env folder /home/eloi/dev/wtforms/wtforms/.tox/.pkg
.pkg: install_requires> python -I -m pip install hatchling
.pkg: install_requires_for_build_sdist> python -I -m pip install 'Babel>=2.6.0'
.pkg: build_sdist> python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True hatchling.build
py312: install_package> python -I -m pip install --force-reinstall --no-deps /home/eloi/dev/wtforms/wtforms/.tox/.tmp/package/40/wtforms-3.1.1.tar.gz
Processing ./.tox/.tmp/package/40/wtforms-3.1.1.tar.gz
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... error

  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [28 lines of output]
      Traceback (most recent call last):
        File "/tmp/pip-build-env-zzbt8fxn/normal/lib/python3.12/site-packages/babel/messages/setuptools_frontend.py", line 7, in <module>
          from setuptools import Command
      ModuleNotFoundError: No module named 'setuptools'

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "/home/eloi/dev/wtforms/wtforms/.tox/py312/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/eloi/dev/wtforms/wtforms/.tox/py312/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/eloi/dev/wtforms/wtforms/.tox/py312/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          whl_basename = backend.build_wheel(metadata_directory, config_settings)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-zzbt8fxn/overlay/lib/python3.12/site-packages/hatchling/build.py", line 58, in build_wheel
          return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-zzbt8fxn/overlay/lib/python3.12/site-packages/hatchling/builders/plugin/interface.py", line 147, in build
          build_hook.initialize(version, build_data)
        File "/tmp/pip-req-build-ds82eg3b/hatch_build.py", line 6, in initialize
          from babel.messages.frontend import compile_catalog
        File "/tmp/pip-build-env-zzbt8fxn/normal/lib/python3.12/site-packages/babel/messages/frontend.py", line 1121, in __getattr__
          from babel.messages import setuptools_frontend
        File "/tmp/pip-build-env-zzbt8fxn/normal/lib/python3.12/site-packages/babel/messages/setuptools_frontend.py", line 15, in <module>
          from distutils.cmd import Command
      ModuleNotFoundError: No module named 'distutils'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
py312: exit 1 (2.97 seconds) /home/eloi/dev/wtforms/wtforms> python -I -m pip install --force-reinstall --no-deps /home/eloi/dev/wtforms/wtforms/.tox/.tmp/package/40/wtforms-3.1.1.tar.gz pid=67429
.pkg: _exit> python /usr/lib/python3.11/site-packages/pyproject_api/_backend.py True hatchling.build
  py312: FAIL code 1 (6.20 seconds)
  evaluation failed :( (6.26 seconds)

@azmeuk azmeuk merged commit 432cba6 into pallets-eco:master Jan 6, 2024
8 checks passed
@azmeuk azmeuk deleted the babel-dep branch January 6, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant