-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add render_kw support (#40) #42
Conversation
Signed-off-by: Jonathan Nagy <[email protected]>
LGTM. Can you add a changelog entry and fix the
Let's do it simple for now, and wait to see if someone ever need a more complexe feature. |
Style fixed. Thanks again. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@jace All good from me, just waiting on someone to merge it. |
Folks, there's no PyPI release yet. Why was that comment deleted? It affects everyone using wtforms-sqlalchemy with the latest release of wtforms. |
@jace Not sure. I'm not associated with the maintainers, sorry. |
I just noticed WTForms 3.1.1 has been released, making |
I was waiting on conflicts on #44 being addressed before cutting a new release. |
WTForms choices iterators have recently changed to expect a tuple of
4 elements. This change provides a callable field
get_render_kw
whichis similar to
get_pk
andget_label
.Note: blank form values have no
obj
reference, so it doesn't makesense to call
get_render_kw
in that scope. For now an empty dictis returned, but maybe it should provide a
blank_render_kw
callable? That's a bit of a design decision that's not up to me.
I've had a quick look at fixing up the unit tests to make them pass, but
nothing substantial has been added to test the get_render_kw return
values.