Chore - fix tests to run w/o flask_sqlalchemy #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 36 36
Lines 4665 4665
=======================================
Hits 4593 4593
Misses 72 72 ☔ View full report in Codecov by Sentry. |
Also - due to python version mismatch between tox and actions - a bunch of actions were being skipped. Have more tests run using all available datastores (rather than the normal just flask_sqlalchemy). A bit of cleanup prior to adding the new flask_sqlalchemy_lite datastore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also - due to python version mismatch between tox and actions - a bunch of actions were being skipped.
Have more tests run using all available datastores (rather than the normal just flask_sqlalchemy).
A bit of cleanup prior to adding the new flask_sqlalchemy_lite datastore.