Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /login and /us-signin to have the same behavior when called by… #986

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jun 5, 2024

… an already authenticated user. They were similar - now identical.

GET w/ JSON now returns the same attributes (possible identity attributes etc) as a GET when not authenticated.

close #973

… an already authenticated user. They were similar - now identical.

GET w/ JSON now returns the same attributes (possible identity attributes etc) as a GET when not authenticated.

close #973
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (19e92f5) to head (6319b87).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files          36       36              
  Lines        4624     4621       -3     
==========================================
- Hits         4552     4549       -3     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwag956 jwag956 merged commit 80a7139 into master Jun 13, 2024
19 checks passed
@jwag956 jwag956 deleted the get973 branch June 13, 2024 21:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

login and unified sign in should handle GET for authenticated user consistently
1 participant