Try a different approach to typing datastores. #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than define our own User model (just for typing) - change the annotations to use UserMixin and as part of typing define each possible member and type. Add annotations to view_scaffold.py - as a test for the new datastore annotations. add pyright config to pyproject.toml - it throws tons of errors - but view_scaffold not passes. closes #1001
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 37 37
Lines 4755 4758 +3
=======================================
+ Hits 4679 4682 +3
Misses 76 76 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than define our own User model (just for typing) - change the annotations to use UserMixin and as part of typing define each possible member and type.
Add annotations to view_scaffold.py - as a test for the new datastore annotations.
add pyright config to pyproject.toml - it throws tons of errors - but view_scaffold not passes.
closes #1001