Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable socket access for responses 0.24+ compatibility #104

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

palazzem
Copy link
Owner

@palazzem palazzem commented Nov 3, 2023

Related Issues

Proposed Changes:

After the change in responses 0.24.0 (getsentry/responses#685) all tests fail as socket.socket is accessed within the library. This change uses socket_enabled fixture from pytest-socket library so that any time an ElmoClient fixture is used, sockets are enabled.

This change should not have negative impacts as responses is still not making any call to external services.

Testing:

Run any test that access client fixture.

Extra Notes (optional):

n/a

Checklist

  • Related issues and proposed changes are filled
  • Tests are defining the correct and expected behavior
  • Code is well-documented via docstrings

@palazzem palazzem added this to the 2.2.0 milestone Nov 3, 2023
@palazzem palazzem self-assigned this Nov 3, 2023
@palazzem palazzem changed the title tests: trigger a CI run tests: enable socket access for responses 0.24+ compatibility Nov 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6746757894

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.357%

Totals Coverage Status
Change from base Build 6677072536: 0.0%
Covered Lines: 475
Relevant Lines: 541

💛 - Coveralls

@palazzem palazzem merged commit 74df799 into main Nov 3, 2023
4 checks passed
@palazzem palazzem deleted the palazzem/issue-103 branch November 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

GitHub actions don't work as socket.socket is accessed
2 participants