tests: enable socket access for responses
0.24+ compatibility
#104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
socket.socket
is accessed #103Proposed Changes:
After the change in
responses
0.24.0 (getsentry/responses#685) all tests fail assocket.socket
is accessed within the library. This change usessocket_enabled
fixture frompytest-socket
library so that any time anElmoClient
fixture is used, sockets are enabled.This change should not have negative impacts as
responses
is still not making any call to external services.Testing:
Run any test that access
client
fixture.Extra Notes (optional):
n/a
Checklist