Allow empty schemas in check markdown task (#802)

Allow empty schemas in check markdown task
palantir · Jun 7, 2022 · 7ca8293 · 7ca8293
1 parent 747732b
commit 7ca8293
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/changelog/@unreleased/pr-802.v2.yml b/changelog/@unreleased/pr-802.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Allow empty schemas in check markdown task
+  links:
+  - https://github.com/palantir/metric-schema/pull/802
diff --git a/...etric-schema/src/main/java/com/palantir/metric/schema/gradle/CheckMetricMarkdownTask.java b/...etric-schema/src/main/java/com/palantir/metric/schema/gradle/CheckMetricMarkdownTask.java
@@ -78,7 +78,7 @@ public final void check() throws IOException {
 
         Map<String, List<MetricSchema>> schemas =
                 ObjectMappers.mapper.readValue(manifest, new TypeReference<Map<String, List<MetricSchema>>>() {});
-        if (schemas.isEmpty()) {
+        if (isEmpty(schemas)) {
             return;
         }
 
@@ -99,4 +99,8 @@ public final void check() throws IOException {
                     MetricSchemaPlugin.GENERATE_METRICS_MARKDOWN);
         }
     }
+
+    private static boolean isEmpty(Map<String, List<MetricSchema>> schemas) {
+        return schemas.isEmpty() || schemas.values().stream().allMatch(List::isEmpty);
+    }
 }