-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write locks if both the locks and props change #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…adle-consistent-versions-idea-plugin into finlayw/dont_refresh_on_lock
CRogers
reviewed
Nov 1, 2024
...dea-plugin/src/main/java/com/palantir/gradle/versions/intellij/VersionPropsFileListener.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Nov 1, 2024
...dea-plugin/src/main/java/com/palantir/gradle/versions/intellij/VersionPropsFileListener.java
Outdated
Show resolved
Hide resolved
FinlayRJW
commented
Nov 11, 2024
...-plugin/src/main/java/com/palantir/gradle/versions/intellij/DebouncingAsyncFileListener.java
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...lugin/src/main/java/com/palantir/gradle/versions/intellij/VersionPropsListenerRegistrar.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...-plugin/src/main/java/com/palantir/gradle/versions/intellij/DebouncingAsyncFileListener.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...-plugin/src/main/java/com/palantir/gradle/versions/intellij/DebouncingAsyncFileListener.java
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...lugin/src/main/java/com/palantir/gradle/versions/intellij/VersionPropsListenerRegistrar.java
Outdated
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...-plugin/src/main/java/com/palantir/gradle/versions/intellij/DebouncingAsyncFileListener.java
Show resolved
Hide resolved
CRogers
reviewed
Nov 11, 2024
...-plugin/src/main/java/com/palantir/gradle/versions/intellij/DebouncingAsyncFileListener.java
Outdated
Show resolved
Hide resolved
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Issue #47 outlined how changing branch triggered a write lock if both props and locks where different
After this PR
We now track both props and locks changes and only trigger locks writes if the locks file has not changed within 350ms of the props file changing
This was slightly more complex than expected as the events that
prepareChange
are batched so you cannot guarantee that the change to props and locks will be in the same call toprepareChange
so you must track state==COMMIT_MSG==
Don't write locks if both the locks and props change
==COMMIT_MSG==
Possible downsides?
This could prevent intentional locks writing if the props and locks change within 350ms of one another