-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primitive array setter optimization [Primitive Arrays Pt.4] #2312
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
@@ -140,11 +141,22 @@ public static <T> Set<T> newNonNullSet(Iterable<? extends T> iterable) { | |||
return set; | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops don't know how I accidentally left the comment block down there :(
@@ -217,4 +245,8 @@ public static List<SafeLong> newNonNullSafeLongList(Iterable<SafeLong> iterable) | |||
|
|||
return safeLongList; | |||
} | |||
|
|||
private static boolean safeLongCheck(long value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated check from SafeLong. Not sure if its worth moving this to be public
I’m currently ooto, but as I mentioned in our last discussion, I don’t want to expand the generated types public api. We have gone to great lengths to avoid and remove code using arrays over well-encapsulated immutable types. Before examining this, it would be helpful to have examples with benchmarks of what we’re trying to resolve, as well as an analysis of the other options which might achieve the desired outcome. |
@carterkozak I modified the methods to copy the array on input, which should protect our expectations around mutability. While it will cost some memory/speed, it's quite a bit more efficient than the boxed list version. Would this be ok to merge? |
Before this PR
Add back optimization removed here: #2274 (comment)
This will allow clients to just track primitive arrays internally which will be a nice perf improvement.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?