fix eclipse warnings #1916
Open
fix eclipse warnings #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove @SuppressWarnings("deprecation") on deprecated methods. The annotation is for suppressing calls of deprecated methods, not implementation of deprecated methods. Only generated _plainSerDe when it is used. Fixes #1635
Generate changelog in
|
ash211
reviewed
Nov 18, 2022
| @@ -75,6 +74,7 @@ public final class DefaultStaticFactoryMethodGenerator implements StaticFactoryM | |||
| private final ParameterTypeMapper parameterTypes; | |||
| private final ReturnTypeMapper returnTypes; | |||
| private final StaticFactoryMethodType methodType; | |||
| private final ThreadLocal<Boolean> shouldGeneratePlainSerDe = ThreadLocal.withInitial(() -> false); | |||
There was a problem hiding this comment.
ThreadLocals have a bunch of gotchas that can be really troublesome to debug. Is there a reason we can't pass info up and down the stack to set this as needed all within the generate() method and its calls?
| methodBuilder.addAnnotation(AnnotationSpec.builder(SuppressWarnings.class) | ||
| .addMember("value", "$S", "deprecation") | ||
| .build()); | ||
| } |
There was a problem hiding this comment.
this change to remove the SuppressWarnings annotations seems independent from the plainSerDe change. Can they be separate PRs, or are they interrelated somehow?
There was a problem hiding this comment.
Moved deprecation stuff to #1917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only generated _plainSerDe when it is used.
Partial fix for #1635
Before this PR
Generated code has a lot of warnings in eclipse.
After this PR
==COMMIT_MSG==
Fix unused warnings in eclipse
==COMMIT_MSG==
Possible downsides?
Untested in intellij since I don't use it. Only tested on a single internal repo.