Adding builder-ubi-buildpackless-base on integration tests #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhdawson
reviewed
Oct 27, 2023
mhdawson
reviewed
Nov 21, 2023
| WithBuildpacks( | ||
| settings.Buildpacks.Yarn.Online, | ||
| settings.Buildpacks.BuildPlan.Online, | ||
| ). |
There was a problem hiding this comment.
Asked @pacostas about this change, it was done to be consistent with all of the other buildpack integration tests.
mhdawson
reviewed
Nov 21, 2023
| Execute(name, source) | ||
| Expect(err).ToNot(HaveOccurred(), logs.String) | ||
|
|
||
| // Ensure yarn is installed correctly | ||
|
|
||
| container, err = docker.Container.Run.WithCommand("which yarn").Execute(image.ID) | ||
| container, err = docker.Container.Run.WithCommand("command -v yarn").Execute(image.ID) |
There was a problem hiding this comment.
I asked @pacostas about this, we don't install which by default in the ubi stack, this allows the test to run for both ubi and jammy
mhdawson
reviewed
Nov 21, 2023
| @@ -155,8 +166,13 @@ func testDefault(t *testing.T, context spec.G, it spec.S) { | |||
| ) | |||
|
|
|||
| image, logs, err = pack.WithNoColor().Build. | |||
| WithPullPolicy("never"). | |||
| WithBuildpacks(buildpack, buildPlanBuildpack). | |||
| WithExtensions( | |||
There was a problem hiding this comment.
Similar change to previous for consistenccy with other buildpack integration tests.
pacostas
force-pushed
the
adding-ubi-buildpackless-builder
branch
from
0dc16e8 to
fcd93be
Compare
|
@mhdawson I added this change https://github.com/paketo-buildpacks/yarn/compare/0dc16e8f1274486fc2de415091428f0a2b097f48..fcd93be671c8ca8a1ce4adef9e24201562a5ac51 Practically is skipping the offline tests, as we cant support them at the moment. Can you LGTM that too? |
…egration tests enabling experimental feature in pack before running integration tests refactor: changing the structure of settings to similar what other buildpacks have fixing the integration tests fix: removing comment
pacostas
force-pushed
the
adding-ubi-buildpackless-builder
branch
from
fcd93be to
52a35b5
Compare
thitch97
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
builder-ubi-buildpackless-basebuilder to run against all the integration tests of yarn.Checklist