Bump gradle wrapper networkTimeout to 10000 in sample #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes
networkTimeout=1
tonetworkTimeout=10000
in the gradle sample gradle-wrapper.properties file and then changes the Action to use that properties file instead of copying a different file.This fixes #642.
Use Cases
We're building our buildpacks in a CI/CD Jenkins pipeline and pushing them to our internal AWS ECR. We're using the samples to test our builds and this sample recently started to fail. I would expect the sample to run out-of-the-box. I'm not a Java developer, so I had limited knowledge of where to start troubleshooting.
I was troubleshooting with @anthonydahanne in a Slack thread and he advised me to make these changes and open this PR.
Checklist