Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle wrapper networkTimeout to 10000 in sample #643

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Bump gradle wrapper networkTimeout to 10000 in sample #643

merged 2 commits into from
Oct 26, 2023

Conversation

lmarchione-r7
Copy link
Contributor

@lmarchione-r7 lmarchione-r7 commented Oct 26, 2023

Summary

This PR changes networkTimeout=1 to networkTimeout=10000 in the gradle sample gradle-wrapper.properties file and then changes the Action to use that properties file instead of copying a different file.

This fixes #642.

Use Cases

We're building our buildpacks in a CI/CD Jenkins pipeline and pushing them to our internal AWS ECR. We're using the samples to test our builds and this sample recently started to fail. I would expect the sample to run out-of-the-box. I'm not a Java developer, so I had limited knowledge of where to start troubleshooting.

I was troubleshooting with @anthonydahanne in a Slack thread and he advised me to make these changes and open this PR.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@lmarchione-r7 lmarchione-r7 requested a review from a team as a code owner October 26, 2023 15:44
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lmarchione-r7 / name: Logan Marchione (271a2ca)
  • ✅ login: ForestEckhardt / name: Forest Eckhardt (d423ad5)

@ForestEckhardt ForestEckhardt merged commit ef87915 into paketo-buildpacks:main Oct 26, 2023
3 checks passed
@anthonydahanne
Copy link
Member

thank you @ForestEckhardt and @lmarchione-r7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle sample not working (timeout error)
3 participants