Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing bionic builder support #976

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Removing bionic builder support #976

merged 1 commit into from
Nov 13, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Nov 6, 2024 •
edited
Loading

Summary

This PR, removes bionic from the integration testing:

  • Bionic builder is archived
  • Bionic builder does support node version >= 22
  • Bionic builder is not supported from the node-engine

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner November 6, 2024 10:22
@pacostas pacostas added the semver:major A change requiring a major version bump label Nov 6, 2024
@pacostas pacostas mentioned this pull request Nov 6, 2024
Merged
c0d1ngm0nk3y
c0d1ngm0nk3y approved these changes Nov 8, 2024
View reviewed changes
Copy link

@c0d1ngm0nk3y c0d1ngm0nk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated: Do you know if there are concrete plans for noble?

@pacostas
Copy link
Contributor Author

pacostas commented Nov 8, 2024

I agree, we should add it. I created a comment to discuss it in the next meeting because I see noble tries to support multiarch and nodejs does not have mutliarch support yet as far as i know. #910

mhdawson
mhdawson approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas merged commit 0793b31 into paketo-buildpacks:main Nov 13, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0d1ngm0nk3y c0d1ngm0nk3y c0d1ngm0nk3y approved these changes

@mhdawson mhdawson mhdawson approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:major A change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @mhdawson @c0d1ngm0nk3y