Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better fix for the nan version upgrade problem (#124). I submitted an earlier PR which "solved" the issue by fixing the version in packages.json (#125). However, I have since found the root cause of the problem (nodejs/nan#716).
It turns out that with nan 2.8.0, the node-sodium build process prints out so many warnings that
child_process.exec
reaches max buffer size, causingnode-gyp rebuild
to be terminated! Since the buffered output is not actually used, this PR solves the issue by replacingexec
withspawn
. Having nan 2.8.0 as a dependency now works fine.