Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't buffer build output #128

Closed
wants to merge 2 commits into from
Closed

Conversation

anibali
Copy link
Contributor

@anibali anibali commented Nov 24, 2017

This is a better fix for the nan version upgrade problem (#124). I submitted an earlier PR which "solved" the issue by fixing the version in packages.json (#125). However, I have since found the root cause of the problem (nodejs/nan#716).

It turns out that with nan 2.8.0, the node-sodium build process prints out so many warnings that child_process.exec reaches max buffer size, causing node-gyp rebuild to be terminated! Since the buffered output is not actually used, this PR solves the issue by replacing exec with spawn. Having nan 2.8.0 as a dependency now works fine.

@anibali anibali mentioned this pull request Nov 24, 2017
@anibali
Copy link
Contributor Author

anibali commented Dec 1, 2017

@paixaop I'm pretty sure that the failing test is unrelated to this PR:

not ok 145 PWHash argon2i should verify the generated hash with same password
  AssertionError: false == true
      at Context.<anonymous> (test/test_crypto_pwhash.js:90:9)

@paixaop
Copy link
Owner

paixaop commented Nov 17, 2018

implemented this change in the master in version 3.0.0. Thanks!

@paixaop paixaop closed this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants