Skip to content

Commit

Permalink
fix: Add variable to manage network access to durable function app st…
Browse files Browse the repository at this point in the history
…orage account (#194)

Co-authored-by: Andrea Grillo <[email protected]>
  • Loading branch information
pasqualedevita and Krusty93 authored Dec 6, 2023
1 parent 9b310ad commit 4cc51a4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 14 deletions.
18 changes: 4 additions & 14 deletions function_app/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,6 @@ module "storage_account_durable_function" {
advanced_threat_protection = false
public_network_access_enabled = false

network_rules = {
default_action = "Deny"
ip_rules = []
bypass = [
"Logging",
"Metrics",
"AzureServices",
]
virtual_network_subnet_ids = [
var.subnet_id
]
}

tags = var.tags
}

Expand Down Expand Up @@ -338,7 +325,10 @@ resource "azurerm_linux_function_app" "this" {
lifecycle {
ignore_changes = [
virtual_network_subnet_id,
app_settings["WEBSITE_HEALTHCHECK_MAXPINGFAILURES"]
app_settings["WEBSITE_HEALTHCHECK_MAXPINGFAILURES"],
tags["hidden-link: /app-insights-conn-string"],
tags["hidden-link: /app-insights-instrumentation-key"],
tags["hidden-link: /app-insights-resource-id"]
]
}

Expand Down
3 changes: 3 additions & 0 deletions function_app_slot/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ resource "azurerm_linux_function_app_slot" "this" {
ignore_changes = [
virtual_network_subnet_id,
app_settings["WEBSITE_HEALTHCHECK_MAXPINGFAILURES"],
tags["hidden-link: /app-insights-conn-string"],
tags["hidden-link: /app-insights-instrumentation-key"],
tags["hidden-link: /app-insights-resource-id"]
]
}

Expand Down

0 comments on commit 4cc51a4

Please sign in to comment.