Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5981] refactor setId in FdUserNotificationToSend and fix retrieveFdProduct in UserUtils #227

Merged
merged 6 commits into from
Nov 14, 2024
Merged

[SELC-5981] refactor setId in FdUserNotificationToSend and fix retrieveFdProduct in UserUtils #227

merged 6 commits into from
Nov 14, 2024

Conversation

flaminiaScarciofolo
Copy link
Collaborator

@flaminiaScarciofolo flaminiaScarciofolo commented Nov 14, 2024 •
edited
Loading

List of Changes

  • refactor setId in FdUserNotificationToSend
  • fix retrieveFdProduct in UserUtils
  • removed repeated subscriber in consumer

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@flaminiaScarciofolo flaminiaScarciofolo requested a review from a team as a code owner November 14, 2024 10:55
@flaminiaScarciofolo flaminiaScarciofolo changed the title [SELC-5981] [SELC-5981] refactor setId in FdUserNotificationToSend and fix retrieveFdProduct in UserUtils Nov 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@flaminiaScarciofolo flaminiaScarciofolo merged commit 3559106 into main Nov 14, 2024
14 of 15 checks passed
@flaminiaScarciofolo flaminiaScarciofolo deleted the feature/SELC-5981 branch November 14, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-putzu andrea-putzu andrea-putzu approved these changes

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
libs user-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaminiaScarciofolo @manuraf @andrea-putzu