Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5648] fix: add productId filter in getInstitutions API #509

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[SELC-5648] fix: add productId filter in getInstitutions API #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac2e65
add productId request param in openapi and align policy
giulia-tremolada Nov 26, 2024
ee158d1
Merge branch 'main' into bugfix/SELC-5648
giulia-tremolada Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions infra/apim_v2/api/ms_external_api/v2/openapi.dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,16 @@
"schema": {
"type": "string"
}
},
{
"name": "productId",
"in": "query",
"description": "productId",
"required": false,
"style": "form",
"schema": {
"type": "string"
}
}
],
"responses": {
Expand Down
10 changes: 10 additions & 0 deletions infra/apim_v2/api/ms_external_api/v2/openapi.prod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,16 @@
"schema": {
"type": "string"
}
},
{
"name": "productId",
"in": "query",
"description": "productId",
"required": false,
"style": "form",
"schema": {
"type": "string"
}
}
],
"responses": {
Expand Down
10 changes: 10 additions & 0 deletions infra/apim_v2/api/ms_external_api/v2/openapi.uat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,16 @@
"schema": {
"type": "string"
}
},
{
"name": "productId",
"in": "query",
"description": "productId",
"required": false,
"style": "form",
"schema": {
"type": "string"
}
}
],
"responses": {
Expand Down
2 changes: 1 addition & 1 deletion infra/apim_v2/apim.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ module "apim_external_api_ms_v2" {
},
{
operation_id = "getInstitutionsUsingGET"
xml_content = templatefile("./api/base_ms_url_external_policy.xml.tpl", {
xml_content = templatefile("./api/base_ms_url_external_product_policy.xml.tpl", {
giulia-tremolada marked this conversation as resolved.
Show resolved Hide resolved
MS_BACKEND_URL = "https://selc-${var.env_short}-ms-core-ca.${var.ca_suffix_dns_private_name}/"
TENANT_ID = data.azurerm_client_config.current.tenant_id
EXTERNAL-OAUTH2-ISSUER = data.azurerm_key_vault_secret.external-oauth2-issuer.value
Expand Down
Loading