[SELC-5886] Fix: handle ADMIN_EA from roles api response

pagopa · Oct 28, 2024 · 377dd8b · 377dd8b
1 parent d935818
commit 377dd8b
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 28 deletions.
diff --git a/src/model/Party.tsx b/src/model/Party.tsx
@@ -4,8 +4,8 @@ import { InstitutionResource } from '../api/generated/b4f-dashboard/InstitutionR
 import { ProductOnBoardingStatusEnum } from '../api/generated/b4f-dashboard/OnboardedProductResource';
 import { ENV } from '../utils/env';
 
-export type UserRole = 'ADMIN' | 'LIMITED';
-export type PartyRole = 'DELEGATE' | 'MANAGER' | 'OPERATOR' | 'SUB_DELEGATE';
+export type UserRole = 'ADMIN' | 'LIMITED' | 'ADMIN_EA';
+export type PartyRole = 'DELEGATE' | 'MANAGER' | 'OPERATOR' | 'SUB_DELEGATE' | 'ADMIN_EA';
 export type UserStatus = 'PENDING' | 'ACTIVE' | 'SUSPENDED' | 'TOBEVALIDATED';
 
 type OnboardedProduct = {

diff --git a/src/model/ProductRole.ts b/src/model/ProductRole.ts
@@ -1,4 +1,5 @@
-import { UserRole, PartyRole } from './Party';
+import { PartyRole, UserRole } from "./Party";
+
 
 export type ProductRole = {
   productId: string;
@@ -20,9 +21,9 @@ export type ProductRolesLists = {
 
 export const buildEmptyProductRolesLists = (): ProductRolesLists => ({
   list: [],
-  groupBySelcRole: { ADMIN: [], LIMITED: [] },
+  groupBySelcRole: { ADMIN: [], LIMITED: [], ADMIN_EA: [] },
   groupByProductRole: {},
-  groupByPartyRole: { MANAGER: [], DELEGATE: [], SUB_DELEGATE: [], OPERATOR: [] },
+  groupByPartyRole: { MANAGER: [], DELEGATE: [], SUB_DELEGATE: [], OPERATOR: [], ADMIN_EA: [] },
 });
 
 export type ProductRolesByProductRoleType = { [productRole: string]: ProductRole };

diff --git a/src/model/__tests__/ProductRole.test.ts b/src/model/__tests__/ProductRole.test.ts
@@ -1,5 +1,5 @@
 import { mockedProductRoles } from '../../services/__mocks__/productService';
-import { ProductRole, productRoles2ProductRolesList } from '../ProductRole';
+import { productRoles2ProductRolesList } from '../ProductRole';
 
 test('Test productRoles2ProductRolesList', () => {
   const rolesList = productRoles2ProductRolesList(mockedProductRoles);
@@ -15,7 +15,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-legale',
           title: 'Referente Legale',
           description: 'Descrizione referente-legale',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
         {
           productId: 'PRODID',
@@ -25,7 +25,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-amministrativo',
           title: 'Amministratore',
           description: 'Descrizione referente-amministrativo',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
         {
           productId: 'PRODID',
@@ -35,7 +35,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'incaricato-ente-creditore',
           title: 'Incaricato Ente Creditore',
           description: 'Descrizione incaricato-ente-creditore',
-          phasesAdditionAllowed: ['dashboard-async']
+          phasesAdditionAllowed: ['dashboard-async'],
         },
       ],
       LIMITED: [
@@ -47,7 +47,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-dei-pagamenti',
           title: 'Referente dei Pagamenti',
           description: 'Descrizione referente-dei-pagamenti',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
         {
           productId: 'PRODID',
@@ -57,9 +57,10 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-tecnico',
           title: 'Referente Tecnico',
           description: 'Descrizione referente-tecnico',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
       ],
+      ADMIN_EA: [],
     },
     groupByPartyRole: {
       DELEGATE: [
@@ -71,7 +72,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-amministrativo',
           selcRole: 'ADMIN',
           title: 'Amministratore',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
       ],
       MANAGER: [
@@ -83,7 +84,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-legale',
           selcRole: 'ADMIN',
           title: 'Referente Legale',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
       ],
       OPERATOR: [
@@ -95,7 +96,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-dei-pagamenti',
           selcRole: 'LIMITED',
           title: 'Referente dei Pagamenti',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
         {
           description: 'Descrizione referente-tecnico',
@@ -105,7 +106,7 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'referente-tecnico',
           selcRole: 'LIMITED',
           title: 'Referente Tecnico',
-          phasesAdditionAllowed: ['dashboard']
+          phasesAdditionAllowed: ['dashboard'],
         },
       ],
       SUB_DELEGATE: [
@@ -117,9 +118,10 @@ test('Test productRoles2ProductRolesList', () => {
           productRole: 'incaricato-ente-creditore',
           selcRole: 'ADMIN',
           title: 'Incaricato Ente Creditore',
-          phasesAdditionAllowed: ['dashboard-async']
+          phasesAdditionAllowed: ['dashboard-async'],
         },
       ],
+      ADMIN_EA: [],
     },
     groupByProductRole: {
       'referente-legale': {
@@ -130,7 +132,7 @@ test('Test productRoles2ProductRolesList', () => {
         productRole: 'referente-legale',
         title: 'Referente Legale',
         description: 'Descrizione referente-legale',
-        phasesAdditionAllowed: ['dashboard']
+        phasesAdditionAllowed: ['dashboard'],
       },
       'referente-amministrativo': {
         productId: 'PRODID',
@@ -140,7 +142,7 @@ test('Test productRoles2ProductRolesList', () => {
         productRole: 'referente-amministrativo',
         title: 'Amministratore',
         description: 'Descrizione referente-amministrativo',
-        phasesAdditionAllowed: ['dashboard']
+        phasesAdditionAllowed: ['dashboard'],
       },
       'incaricato-ente-creditore': {
         productId: 'PRODID',
@@ -150,7 +152,7 @@ test('Test productRoles2ProductRolesList', () => {
         productRole: 'incaricato-ente-creditore',
         title: 'Incaricato Ente Creditore',
         description: 'Descrizione incaricato-ente-creditore',
-        phasesAdditionAllowed: ['dashboard-async']
+        phasesAdditionAllowed: ['dashboard-async'],
       },
       'referente-dei-pagamenti': {
         productId: 'PRODID',
@@ -160,7 +162,7 @@ test('Test productRoles2ProductRolesList', () => {
         productRole: 'referente-dei-pagamenti',
         title: 'Referente dei Pagamenti',
         description: 'Descrizione referente-dei-pagamenti',
-        phasesAdditionAllowed: ['dashboard']
+        phasesAdditionAllowed: ['dashboard'],
       },
       'referente-tecnico': {
         productId: 'PRODID',
@@ -170,7 +172,7 @@ test('Test productRoles2ProductRolesList', () => {
         productRole: 'referente-tecnico',
         title: 'Referente Tecnico',
         description: 'Descrizione referente-tecnico',
-        phasesAdditionAllowed: ['dashboard']
+        phasesAdditionAllowed: ['dashboard'],
       },
     },
   });

diff --git a/src/pages/dashboard/Dashboard.tsx b/src/pages/dashboard/Dashboard.tsx
@@ -130,13 +130,8 @@ const Dashboard = () => {
     )
   );
 
-  const authorizedDelegableProducts: Array<Product> = activeProducts.filter((ap) =>
-    party?.products.some(
-      (p) =>
-        p.productId === ap.id &&
-        hasPermission(p.productId, Actions.AccessProductBackoffice) &&
-        ap.delegable
-    )
+  const authorizedDelegableProducts: Array<Product> = delegableProducts.filter((ap) =>
+    hasPermission(ap.id ?? '', Actions.AccessProductBackoffice)
   );
 
   const canAggregatorSeeHandleDelegations = useMemo(() => {