-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAGOPA-1841] feat: refactored queries in order to include intermediate steps #10
Conversation
The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually. |
The default action is to increase the |
Comment this PR with update_code to format the code. Consider to use pre-commit to format the code. |
Quality Gate failedFailed conditions |
|
||
public String obfuscateSecrets(String httpHeaders) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to me, but why not just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In certain situations, like the paaInviaRT
send process, if the communication fails because of an error on Forwarder or on creditor institution, it may be useful to know whether the wisp-converter sends this header or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 💯
just a note: check sonar issue
The Technical Support APIs are a valid tool for describe events in monitoring situation. For WISP dismantling, this tool was not correctly tuned because this flow provide an high number of intermediate steps that describe the payment process in a detailed way. The previous APIs in WISP dismantling's Technical Support does not provide all the steps that were required for a detailed monitoring.
This PR contains a whole refactoring of those API. In particular, the starting query is converted into a larger set of queries that take all the necessary information from RE and returns a final batch of events with all the intermediate steps.
Also, this PR contains the conversion logic that provide the
Ocp-Apim-Subscription-Key
header logged in RE events to be obfuscated and secured.List of Changes
find-by-notice-number
APIfind-by-iuv
APIMotivation and Context
This change is required for better perform monitoring on WISP dismantling process
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: