Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPANTT-178] fix: Improve iban and CI cron job #520

Merged
merged 33 commits into from
Nov 12, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Nov 5, 2024

List of Changes

  • refactor brokerCiExport cron
  • refactor brokerIbansExport cron
  • replaced MongoClient with MongoTemplate
  • modified error handling in order to do not break cron execution for single failures
  • change cron schedule time in order to not execute cron job at the same time
  • updated unit tests

Motivation and Context

Avoid OOM error during cron execution, improve code, error handling and logs

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added enhancement New feature or request minor labels Nov 5, 2024
@gioelemella gioelemella marked this pull request as draft November 5, 2024 10:15
@gioelemella gioelemella changed the title [PPANTT-178] fiix: Improve iban and CI cron job [PPANTT-178] fix: Improve iban and CI cron job Nov 8, 2024
@gioelemella gioelemella force-pushed the PPANTT-178-bo-improve-iban-and-ci-cron-job branch from f2467df to ed4eac5 Compare November 8, 2024 15:31
@gioelemella gioelemella marked this pull request as ready for review November 11, 2024 09:56
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@gioelemella gioelemella merged commit 163b3cd into main Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants