Skip to content

Commit

Permalink
[PRDP-254] updated unit tests and removed useless classes
Browse files Browse the repository at this point in the history
  • Loading branch information
giomella committed Nov 30, 2023
1 parent 36da502 commit 678e656
Show file tree
Hide file tree
Showing 6 changed files with 354 additions and 277 deletions.
6 changes: 4 additions & 2 deletions src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverNotNotifiedReceipt.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ public HttpResponseMessage run(
.body(ProblemJson.builder()
.title(HttpStatus.BAD_REQUEST.name())
.detail("Please pass a valid biz-event id")
.status(HttpStatus.BAD_REQUEST.value()))
.status(HttpStatus.BAD_REQUEST.value())
.build())
.build();
}

Expand All @@ -97,7 +98,8 @@ public HttpResponseMessage run(
.body(ProblemJson.builder()
.title(HttpStatus.INTERNAL_SERVER_ERROR.name())
.detail(responseMsg)
.status(HttpStatus.INTERNAL_SERVER_ERROR.value()))
.status(HttpStatus.INTERNAL_SERVER_ERROR.value())
.build())
.build();
}

Expand Down
6 changes: 4 additions & 2 deletions src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverNotNotifiedReceiptMassive.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ public HttpResponseMessage run(
.body(ProblemJson.builder()
.title(HttpStatus.BAD_REQUEST.name())
.detail("Please pass a status to recover")
.status(HttpStatus.BAD_REQUEST.value()))
.status(HttpStatus.BAD_REQUEST.value())
.build())
.build();
}

Expand All @@ -88,7 +89,8 @@ public HttpResponseMessage run(
.body(ProblemJson.builder()
.title(HttpStatus.INTERNAL_SERVER_ERROR.name())
.detail(responseMsg)
.status(HttpStatus.INTERNAL_SERVER_ERROR.value()))
.status(HttpStatus.INTERNAL_SERVER_ERROR.value())
.build())
.build();
}

Expand Down
16 changes: 0 additions & 16 deletions src/main/java/it/gov/pagopa/receipt/pdf/helpdesk/model/NotNotifiedRecoveryRequest.java
View file

This file was deleted.

250 changes: 250 additions & 0 deletions src/test/java/it/gov/pagopa/receipt/pdf/helpdesk/RecoverNotNotifiedReceiptMassiveTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,250 @@
package it.gov.pagopa.receipt.pdf.helpdesk;

import com.azure.cosmos.models.FeedResponse;
import com.microsoft.azure.functions.ExecutionContext;
import com.microsoft.azure.functions.HttpRequestMessage;
import com.microsoft.azure.functions.HttpResponseMessage;
import com.microsoft.azure.functions.HttpStatus;
import com.microsoft.azure.functions.OutputBinding;
import it.gov.pagopa.receipt.pdf.helpdesk.client.ReceiptCosmosClient;
import it.gov.pagopa.receipt.pdf.helpdesk.entity.receipt.ReasonError;
import it.gov.pagopa.receipt.pdf.helpdesk.entity.receipt.Receipt;
import it.gov.pagopa.receipt.pdf.helpdesk.entity.receipt.enumeration.ReceiptStatusType;
import it.gov.pagopa.receipt.pdf.helpdesk.model.ProblemJson;
import it.gov.pagopa.receipt.pdf.helpdesk.util.HttpResponseMessageMock;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.mockito.Spy;
import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.stubbing.Answer;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Optional;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

@ExtendWith(MockitoExtension.class)
class RecoverNotNotifiedReceiptMassiveTest {

private static final String EVENT_ID = "eventId";

private final ExecutionContext executionContextMock = mock(ExecutionContext.class);

@Mock
private ReceiptCosmosClient receiptCosmosClientMock;

@Mock
private HttpRequestMessage<Optional<String>> requestMock;

@Spy
private OutputBinding<List<Receipt>> documentReceipts;

@Captor
private ArgumentCaptor<List<Receipt>> receiptCaptor;

private RecoverNotNotifiedReceiptMassive sut;

private AutoCloseable closeable;

@BeforeEach
public void openMocks() {
closeable = MockitoAnnotations.openMocks(this);
sut = spy(new RecoverNotNotifiedReceiptMassive(receiptCosmosClientMock));
}

@AfterEach
public void releaseMocks() throws Exception {
closeable.close();
}

@Test
void recoverNotNotifiedReceiptMassiveForIOErrorToNotifySuccess() {
FeedResponse feedResponseMock = mock(FeedResponse.class);
List<Receipt> receiptList = getReceiptList(ReceiptStatusType.IO_ERROR_TO_NOTIFY);
when(feedResponseMock.getResults()).thenReturn(receiptList);
when(receiptCosmosClientMock.getNotNotifiedReceiptDocuments(any(), any(), any()))
.thenReturn(Collections.singletonList(feedResponseMock));

doAnswer((Answer<HttpResponseMessage.Builder>) invocation -> {
HttpStatus status = (HttpStatus) invocation.getArguments()[0];
return new HttpResponseMessageMock.HttpResponseMessageBuilderMock().status(status);
}).when(requestMock).createResponseBuilder(any(HttpStatus.class));

// test execution
HttpResponseMessage response = sut.run(requestMock, ReceiptStatusType.IO_ERROR_TO_NOTIFY, documentReceipts, executionContextMock);

// test assertion
assertNotNull(response);
assertEquals(HttpStatus.OK, response.getStatus());
assertNotNull(response.getBody());

verify(documentReceipts).setValue(receiptCaptor.capture());

assertEquals(receiptList.size(), receiptCaptor.getValue().size());
Receipt captured1 = receiptCaptor.getValue().get(0);
assertEquals(ReceiptStatusType.GENERATED, captured1.getStatus());
assertEquals(EVENT_ID, captured1.getEventId());
assertEquals(0, captured1.getNotificationNumRetry());
assertNull(captured1.getReasonErr());
assertNull(captured1.getReasonErrPayer());
Receipt captured2 = receiptCaptor.getValue().get(0);
assertEquals(ReceiptStatusType.GENERATED, captured2.getStatus());
assertEquals(EVENT_ID, captured2.getEventId());
assertEquals(0, captured2.getNotificationNumRetry());
assertNull(captured2.getReasonErr());
assertNull(captured2.getReasonErrPayer());
}

@Test
void recoverNotNotifiedReceiptMassiveForGeneratedSuccess() {
FeedResponse feedResponseMock = mock(FeedResponse.class);
List<Receipt> receiptList = getReceiptList(ReceiptStatusType.GENERATED);
when(feedResponseMock.getResults()).thenReturn(receiptList);
when(receiptCosmosClientMock.getNotNotifiedReceiptDocuments(any(), any(), any()))
.thenReturn(Collections.singletonList(feedResponseMock));

doAnswer((Answer<HttpResponseMessage.Builder>) invocation -> {
HttpStatus status = (HttpStatus) invocation.getArguments()[0];
return new HttpResponseMessageMock.HttpResponseMessageBuilderMock().status(status);
}).when(requestMock).createResponseBuilder(any(HttpStatus.class));

// test execution
HttpResponseMessage response = sut.run(requestMock, ReceiptStatusType.GENERATED, documentReceipts, executionContextMock);

// test assertion
assertNotNull(response);
assertEquals(HttpStatus.OK, response.getStatus());
assertNotNull(response.getBody());

verify(documentReceipts).setValue(receiptCaptor.capture());

assertEquals(receiptList.size(), receiptCaptor.getValue().size());
Receipt captured1 = receiptCaptor.getValue().get(0);
assertEquals(ReceiptStatusType.GENERATED, captured1.getStatus());
assertEquals(EVENT_ID, captured1.getEventId());
assertEquals(0, captured1.getNotificationNumRetry());
assertNull(captured1.getReasonErr());
assertNull(captured1.getReasonErrPayer());
Receipt captured2 = receiptCaptor.getValue().get(0);
assertEquals(ReceiptStatusType.GENERATED, captured2.getStatus());
assertEquals(EVENT_ID, captured2.getEventId());
assertEquals(0, captured2.getNotificationNumRetry());
assertNull(captured2.getReasonErr());
assertNull(captured2.getReasonErrPayer());
}

@Test
void recoverNotNotifiedReceiptMassiveSuccessWithNoReceiptUpdated() {
FeedResponse feedResponseMock = mock(FeedResponse.class);
when(feedResponseMock.getResults()).thenReturn(Collections.emptyList());
when(receiptCosmosClientMock.getNotNotifiedReceiptDocuments(any(), any(), any()))
.thenReturn(Collections.singletonList(feedResponseMock));

doAnswer((Answer<HttpResponseMessage.Builder>) invocation -> {
HttpStatus status = (HttpStatus) invocation.getArguments()[0];
return new HttpResponseMessageMock.HttpResponseMessageBuilderMock().status(status);
}).when(requestMock).createResponseBuilder(any(HttpStatus.class));

// test execution
HttpResponseMessage response = sut.run(requestMock, ReceiptStatusType.IO_ERROR_TO_NOTIFY, documentReceipts, executionContextMock);

// test assertion
assertNotNull(response);
assertEquals(HttpStatus.OK, response.getStatus());
assertNotNull(response.getBody());

verify(documentReceipts, never()).setValue(receiptCaptor.capture());
}

@Test
void recoverReceiptFailMissingQueryParam() {
doAnswer((Answer<HttpResponseMessage.Builder>) invocation -> {
HttpStatus status = (HttpStatus) invocation.getArguments()[0];
return new HttpResponseMessageMock.HttpResponseMessageBuilderMock().status(status);
}).when(requestMock).createResponseBuilder(any(HttpStatus.class));

// test execution
HttpResponseMessage response = sut.run(requestMock, null, documentReceipts, executionContextMock);

// test assertion
assertNotNull(response);
assertEquals(HttpStatus.INTERNAL_SERVER_ERROR, response.getStatus());

ProblemJson problemJson = (ProblemJson) response.getBody();
assertNotNull(problemJson);
assertEquals(HttpStatus.BAD_REQUEST.value(), problemJson.getStatus());
assertEquals(HttpStatus.BAD_REQUEST.name(), problemJson.getTitle());
assertNotNull(problemJson.getDetail());

verify(documentReceipts, never()).setValue(receiptCaptor.capture());
}

@Test
void recoverReceiptFailInvalidRestoreStatusRequested() {
doAnswer((Answer<HttpResponseMessage.Builder>) invocation -> {
HttpStatus status = (HttpStatus) invocation.getArguments()[0];
return new HttpResponseMessageMock.HttpResponseMessageBuilderMock().status(status);
}).when(requestMock).createResponseBuilder(any(HttpStatus.class));

// test execution
HttpResponseMessage response = sut.run(requestMock, ReceiptStatusType.FAILED, documentReceipts, executionContextMock);

// test assertion
assertNotNull(response);
assertEquals(HttpStatus.INTERNAL_SERVER_ERROR, response.getStatus());

ProblemJson problemJson = (ProblemJson) response.getBody();
assertNotNull(problemJson);
assertEquals(HttpStatus.INTERNAL_SERVER_ERROR.value(), problemJson.getStatus());
assertEquals(HttpStatus.INTERNAL_SERVER_ERROR.name(), problemJson.getTitle());
assertNotNull(problemJson.getDetail());

verify(documentReceipts, never()).setValue(receiptCaptor.capture());
}

private Receipt buildReceipt(ReceiptStatusType statusType) {
return Receipt.builder()
.eventId(EVENT_ID)
.status(statusType)
.reasonErr(ReasonError.builder()
.code(500)
.message("error message")
.build())
.reasonErrPayer(ReasonError.builder()
.code(500)
.message("error message")
.build())
.numRetry(0)
.notificationNumRetry(6)
.insertedAt(0)
.generatedAt(0)
.notifiedAt(0)
.build();
}

private List<Receipt> getReceiptList(ReceiptStatusType statusType) {
List<Receipt> receiptList = new ArrayList<>();
Receipt receipt1 = buildReceipt(statusType);
Receipt receipt2 = buildReceipt(statusType);
receiptList.add(receipt1);
receiptList.add(receipt2);
return receiptList;
}
}
Loading

0 comments on commit 678e656

Please sign in to comment.