feat: [CHK-3613] Updated GET transactions to include optional fields for closePayment errors #2644
+770
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanueleBVtech
requested review from
CianoDanilo,
pietro-tota and
scaminati-bv
5 tasks
EmanueleBVtech
changed the title
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-checkout/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-checkout/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-io/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-webview/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
…son.tpl Co-authored-by: Pietro Tota <[email protected]>
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-checkout/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-checkout/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
| host = local.apim_hostname | ||
| }) | ||
|
|
||
| xml_content = templatefile("./api/ecommerce-webview/v1/_base_policy.xml.tpl", { |
There was a problem hiding this comment.
please create a v2 base policy file where base url have to be set as per the v1 version adding a leading /v2
pietro-tota
reviewed
Dec 12, 2024
src/domains/ecommerce-app/api/ecommerce-checkout/v2/_openapi.json.tpl
Outdated
Show resolved
Hide resolved
pietro-tota
reviewed
Dec 12, 2024
| "$ref": "#/components/schemas/PaymentInfo" | ||
| }, | ||
| "minItems": 1, | ||
| "maxItems": 1, |
There was a problem hiding this comment.
Suggested change
| "maxItems": 1, | |
| "maxItems": 5, |
max payment notices are 5 (cart supports 5 as maximum value).
Please update other api spec definitions too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Added the v2 GET transactions to include an optional object for the close payment error details in:
Also, field reformat for TransactionInfo now adds 2 structures nodeInfos and gatewayInfo, to better aggregate data
Motivation and context
This is part of a bigger effort aiming to have a proper mapping for closePayment errors in the whole platform
Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)