Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [PagoPa-1763] - transaction response adjustment #61

Merged
merged 6 commits into from
May 22, 2024
Merged

feat: [PagoPa-1763] - transaction response adjustment #61

merged 6 commits into from
May 22, 2024

Conversation

alessio-acitelli
Copy link
Collaborator

@alessio-acitelli alessio-acitelli commented May 21, 2024 •
edited
Loading

depends on: BizEventDatastore
depends on: INFRA

List of Changes

  • modified the answer for the list of transactions and the detail of the single transaction

Motivation and Context

  • business request

How Has This Been Tested?

  • manual and junit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alessio-acitelli alessio-acitelli marked this pull request as ready for review May 22, 2024 14:56
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner May 22, 2024 14:56
pasqualespica
pasqualespica approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@pasqualespica pasqualespica merged commit 66efa49 into main May 22, 2024
17 of 19 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1763-transaction-response-adjustment branch May 22, 2024 15:10
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
patch size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @pasqualespica @pagopa-github-bot