Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-349] feat: Rework TransactionList API #38

Merged
merged 24 commits into from
Feb 1, 2024

Conversation

svariant
Copy link
Collaborator

TO BE MERGED AFTER PR 37

List of Changes

  • Reworked TransactionList API with the changes to the services defined in the analisys
  • Rewritten unit tests

Motivation and Context

Issue PRDP-349

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant self-assigned this Jan 30, 2024
@svariant svariant added enhancement New feature or request minor labels Jan 30, 2024
@svariant svariant marked this pull request as ready for review February 1, 2024 14:11
@svariant svariant requested a review from a team as a code owner February 1, 2024 14:11
# Conflicts:
#	src/main/java/it/gov/pagopa/bizeventsservice/controller/ITransactionController.java
#	src/main/java/it/gov/pagopa/bizeventsservice/controller/impl/TransactionController.java
#	src/main/java/it/gov/pagopa/bizeventsservice/service/ITransactionService.java
#	src/main/java/it/gov/pagopa/bizeventsservice/service/impl/TransactionService.java
# Conflicts:
#	src/main/java/it/gov/pagopa/bizeventsservice/controller/ITransactionController.java
#	src/main/java/it/gov/pagopa/bizeventsservice/entity/view/BizEventsViewGeneral.java
#	src/main/java/it/gov/pagopa/bizeventsservice/entity/view/BizEventsViewUser.java
#	src/main/java/it/gov/pagopa/bizeventsservice/exception/AppError.java
#	src/main/java/it/gov/pagopa/bizeventsservice/mapper/ConvertViewsToTransactionDetailResponse.java
#	src/main/java/it/gov/pagopa/bizeventsservice/repository/BizEventsViewCartRepository.java
#	src/main/java/it/gov/pagopa/bizeventsservice/repository/BizEventsViewGeneralRepository.java
#	src/main/java/it/gov/pagopa/bizeventsservice/repository/BizEventsViewUserRepository.java
#	src/main/java/it/gov/pagopa/bizeventsservice/service/impl/TransactionService.java
#	src/main/java/it/gov/pagopa/bizeventsservice/util/Constants.java
#	src/test/java/it/gov/pagopa/bizeventsservice/controller/TransactionControllerTest.java
#	src/test/java/it/gov/pagopa/bizeventsservice/service/TransactionServiceTest.java
#	src/test/java/it/gov/pagopa/bizeventsservice/util/ViewGenerator.java
@pasqualespica pasqualespica merged commit a330f05 into main Feb 1, 2024
9 of 11 checks passed
@pasqualespica pasqualespica deleted the PRDP-349-rework-tranasctionList-api branch February 1, 2024 14:45
Copy link

github-actions bot commented Feb 1, 2024

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants