Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: P4ADEV-1545 fdr ingestion actity implementation retrieval via query file validation #22

Conversation

macacia
Copy link
Collaborator

@macacia macacia commented Nov 27, 2024

Description

Implementation of the following steps:

  • validate the file (it exists, md5)
  • decrypt (in temporary directory)
  • zip security checks? (is it a zip?)
  • possible unzip (in temporary directory)

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
38.6% Coverage on New Code (required ≥ 80%)
E Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

antonioT90
antonioT90 previously approved these changes Dec 3, 2024
…ionActity-implementation-retrieval-via-query-file-validation

# Conflicts:
#	version
antonioT90
antonioT90 previously approved these changes Dec 3, 2024
@macacia macacia merged commit 3993ebe into main Dec 4, 2024
8 checks passed
@macacia macacia deleted the P4ADEV-1545-FdRIngestionActity-implementation-retrieval-via-query-file-validation branch December 4, 2024 10:26
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants