review code with requested changes

pagopa · Jan 2, 2025 · 3564edf · 3564edf
1 parent c94c215
commit 3564edf
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/.../gov/pagopa/payhub/activities/activity/classifications/IufClassificationActivityImpl.java b/.../gov/pagopa/payhub/activities/activity/classifications/IufClassificationActivityImpl.java
@@ -34,7 +34,7 @@ public IufClassificationActivityResult classify(Long organizationId, Long treasu
             .map(paymentsReportingDTO ->
                 Transfer2ClassifyDTO.builder()
                     .iuv(paymentsReportingDTO.getIuv())
-                    .iur(paymentsReportingDTO.getRegulationUniqueIdentifier())
+                    .iur(paymentsReportingDTO.getIur())
                     .transferIndex(paymentsReportingDTO.getTransferIndex())
                     .build())
             .toList();

diff --git a/...pagopa/payhub/activities/activity/classifications/TransferClassificationActivityImpl.java b/...pagopa/payhub/activities/activity/classifications/TransferClassificationActivityImpl.java
@@ -40,7 +40,7 @@ public void classify(Long orgId, String iuv, String iur, int transferIndex) {
 
 		log.info("Retrieve payment reporting for organization id: {} and iuv: {} and iur {} and transfer index: {}", orgId, iuv, iur, transferIndex);
 		PaymentsReportingDTO paymentsReportingDTO =  paymentsReportingDao.findBySemanticKey(orgId, iuv, iur, transferIndex);
-		if (paymentsReportingDTO!=null && StringUtils.isNotEmpty(paymentsReportingDTO.getIuf())) {
+		if (paymentsReportingDTO!=null) {
 			String iuf = paymentsReportingDTO.getIuf();
 			log.info("Retrieve treasury for organization id: {} and iuf {}", orgId, iuf);
 			treasuryDao.getByOrganizationIdAndIuf(orgId, iuf);

diff --git a/.../gov/pagopa/payhub/activities/activity/classifications/IufClassificationActivityTest.java b/.../gov/pagopa/payhub/activities/activity/classifications/IufClassificationActivityTest.java
@@ -60,7 +60,7 @@ void givenReportedTransferWhenClassifyThenOk() {
                 .map(paymentsReportingDTO ->
                     Transfer2ClassifyDTO.builder()
                         .iuv(paymentsReportingDTO.getIuv())
-                        .iur(paymentsReportingDTO.getRegulationUniqueIdentifier())
+                        .iur(paymentsReportingDTO.getIur())
                         .transferIndex(paymentsReportingDTO.getTransferIndex())
                         .build())
                 .toList();

diff --git a/src/test/java/it/gov/pagopa/payhub/activities/utility/faker/PaymentsReportingFaker.java b/src/test/java/it/gov/pagopa/payhub/activities/utility/faker/PaymentsReportingFaker.java
@@ -9,7 +9,7 @@ public static PaymentsReportingDTO buildClassifyResultDTO(){
                 .organizationId(1L)
                 .iuf("IUF")
                 .iuv("IUV")
-                .regulationUniqueIdentifier("IUR")
+                .iur("IUR")
                 .transferIndex(1)
                 .build();
     }

diff --git a/version b/version
@@ -1 +1 @@
-1.23.10-SNAPSHOT
+1.23.11t add .-SNAPSHOT