feat: refactor lambda service metadata #584
Open
+789
−533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenitoVisone
had a problem deploying
to
prod/eu-south-1
GitHub Actions
Failure
BenitoVisone
temporarily deployed
to
prod/eu-central-1
GitHub Actions
Inactive
uolter
reviewed
Jan 3, 2025
| stream_enabled = optional(bool, false) | ||
| stream_view_type = optional(string, null) | ||
| stream_enabled = optional(bool, true) | ||
| stream_view_type = optional(string, "NEW_AND_OLD_IMAGES") |
There was a problem hiding this comment.
Could it be that only NEW images are sufficient?
There was a problem hiding this comment.
We need the "NEW_AND_OLD_IMAGES" to compare the item versions during lambda execution
…t/refactor-lambda-service-metadata
uolter
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Error
…b.com/pagopa/oneidentity into feat/refactor-lambda-service-metadata
uolter
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Error
uolter
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
oneid-lambda-service-metadatarefactoring.In particular, the lambda will be executed when a new Client is registered, updating the metadata files on the metadata bucket (
spid.xmlandcie.xmlfiles).Furthermore, these files will be accessed via
API Gatewayintegration at:https://oneid.pagopa.it/saml/spid/metadatahttps://oneid.pagopa.it/saml/cie/metadata