Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1326] Changed base path to be aligned with other external apis #91

Merged
merged 1 commit into from
May 8, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Moved external base path to /api/v1/messages-sending.
Moved internal base path to /api/v1/messages-sending/internal.
Used messages-sending as product name to be compliant with azure functions name and not with repo name.

Motivation and Context

We need to align openapi specs to the existing ones.

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@lucacavallaro lucacavallaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I'm not a fan of these URI, especially the internal ones. But - given the current structure of our APIM - we cannot do otherwise)

Copy link

@iwoak iwoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a solution, possible, better than the previous one

@michaeldisaro
Copy link
Contributor Author

LGTM

(I'm not a fan of these URI, especially the internal ones. But - given the current structure of our APIM - we cannot do otherwise)

You got it! :trollface:

@michaeldisaro michaeldisaro merged commit f15bec9 into master May 8, 2024
7 checks passed
@michaeldisaro michaeldisaro deleted the iocom-1326 branch May 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants