Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for specification v3 combined matchers #86

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximvl
Copy link

@maximvl maximvl commented Jan 19, 2021

Hello, following the discussion here pact-foundation/pact-js#51 I experimented with v3 combine matchers and it seems it can be used to implement optional types.
As I'm not an expert in Ruby feel free to comment on style/logic. I will take care of tests and improvements later.

@maximvl
Copy link
Author

maximvl commented Jan 20, 2021

Recently I found there is a python implementation which supports v3, i think it will be enough for my case. closing this one.

@maximvl maximvl closed this Jan 20, 2021
@bethesque bethesque reopened this Jan 21, 2021
@bethesque
Copy link
Member

I might keep going on this, as it needs to be implemented anyway.

@dimitar-aleksov-cardano
Copy link

@maximvl I know it's been years since this issue was discussed, but could you point me to this python implementation, that makes use of the combine matcher? I am running into the same issue, that was discussed in pact-foundation/pact-js#51, my provider API returns a list of objects and some of the fields are optional. Therefore, I'd like to make use of a kind of combine matcher, that verifies both None and complex objects. Thanks in advance!

@YOU54F YOU54F marked this pull request as draft August 14, 2024 14:11
@YOU54F
Copy link
Member

YOU54F commented Aug 14, 2024

converting this to a draft, as there is some additional work required before this can be merged

@dimitar-aleksov-cardano - please follow the pact-python blog, it currently doesn't support v3 combined matchers but it ia moving towards the pact-rust implementation which does.

https://pact-foundation.github.io/pact-python/blog/

The tracking ticket is pact-foundation/pact-python#396

it is worth noting that pact-jvm supports AND/OR from V3 spec compat onwards however pact-reference does not expose the OR functionality via the FFI which client libraries will be leveraging for shared core functionality (migrating away from the rust core which most libraries have now down)

pact-foundation/pact-reference#399 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants