refactor(dependencies): Move webrick to be a pure development dependency. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy. Webrick was originally part of the pact application, but is now purely used to support testing. Also, to quote Jeremy Evans ruby/webrick#145 (comment) > Webrick has not been part of Ruby since the release of Ruby 3.0, over three years ago. While this repository is under the ruby organization on GitHub, it is no longer considered part of Ruby. > > Webrick should not be used in production. It is only still maintained because there are other gems relying it, most of which do so only for testing, and only because it is a pure ruby implementation and it was shipped with Ruby in the past. As Webrick has recently seen a number of CVEs, pulling Webrick in to other codebases unecessarily causes security related maintenance. It's still fine for testing.
|
makes sense Jonathon, cheers for the PR and reference link |
|
Oh well. It probably won't make much of a difference immediately, but if pact_mock-service ever switches to an alternative, then there's a little less cleanup in the future here. Thanks for triple-checking the PR 😁 |
|
Agreed! Hopefully we may be able to, especially as we move towards leveraging the FFI for the rust based core. What is the go to replacement for webrick these days? Might be worth adding an issue to track its removal over in pact_mock-service
Pleasure dude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webrick was originally part of the pact application, but is now purely used to support testing.
Also, to quote Jeremy Evans ruby/webrick#145 (comment)
As Webrick has recently seen a number of CVEs, pulling Webrick in to other codebases unecessarily causes security related maintenance.
It's still fine for testing.