feat: Handle x509 certs in HTTP Client #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will merge when this uses the same approach we agreed on for the pact broker client. |
|
Can you please add docs for this as well. I think the best place to document it is here https://docs.pact.io/implementation_guides/ruby/configuration Would you mind adding the docs for the SSL certs while you're at it? |
This was referenced Oct 10, 2023
|
Thanks for the updates @gmolki 👍🏾 |
YOU54F
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to enable the usage of x509 certificates in http requests.
Related PR in pact-support: pact-foundation/pact-support#99