chore: reduce ci usage #480
Conversation
JP-Ellis
force-pushed
the
chore/reduce-ci-usage
branch
from
99969cb to
058df48
Compare
This should help reduce the CI usage by: 1. Only running CI on either: - PRs targetting `master` - pushes to `master` Most importantly, CI is no longer doubled in PRs (as previously, `push` and `pull_request` would _both_ be triggered). 2. Cancelling existing runs if a new commit is added Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/reduce-ci-usage
branch
from
058df48 to
9925028
Compare
The building of dependencies takes a lot of time, providing no benefit to splitting the CI in each version. Instead, combine them all and use nextest to speed up tests. Signed-off-by: JP-Ellis <[email protected]>
Nextest is typically faster to run Signed-off-by: JP-Ellis <[email protected]>
Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/reduce-ci-usage
branch
from
1519b88 to
2a5510b
Compare
Signed-off-by: JP-Ellis <[email protected]>
Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/reduce-ci-usage
branch
2 times, most recently
from
4c2114d to
535f174
Compare
Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/reduce-ci-usage
branch
from
535f174 to
f80cf9f
Compare
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref || github.run_id }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
I'll remove that, that would be annoying. Imagine waiting for a build, then someone else pushes a commit.
There was a problem hiding this comment.
The concurrency group is per-PR, or per branch in the case of a push trigger (which would only happen in master).
So two PRs can have CI running concurrently with no issue; and if two PRs merge in quick succession, the second merge will cancel the first. But once merged, there shouldn't be any waiting
There was a problem hiding this comment.
So there should not be a case of waiting for a build, and it being canceled by someone else's push except if you are both working on the same PR.
If you want this to run specifically when creating tagged released, I recommend creating a separate trigger for tags.
This should help reduce the CI usage by:
Only running CI on either:
mastermasterMost importantly, CI is no longer doubled in PRs (as previously,
pushandpull_requestwould both be triggered, consuming double the number of runners).Cancelling existing runs if a new commit is added
Speeding up some existing builds by not unnecessarily rebuilding everything (especially with the compatibility suite)
Using nextest in place of
cargo testas it is typically fasterUsing caching of build dependencies where possible