feat(cli): support PACT_PLUGIN_CLI_SKIP_LOAD #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow skipping the auto load of plugins, to allow installing the avro plugin whilst we sort the below snag which will be introduced by #69
Avro plugin has failed to load on windows since moving to threads in commit
Amending the following logback.xml from the installed pact-avro-plugin
From
https://github.com/austek/pact-avro-plugin/blob/main/modules/plugin/src/main/resources/logback.xml
To
will allow the plugin framework to pick up the plugins loaded message (serverKey and port).
So there may be a change required in the pact-avro-plugin to support.
This can easily be reproduced with on a windows machine by performing
pact-plugin-cli install -y avro