Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): --skip-if-installed always skipped #45

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(cli): --skip-if-installed always skipped #45

merged 1 commit into from
Oct 4, 2023

Conversation

mefellows
Copy link
Member

@mefellows mefellows commented Oct 3, 2023 •
edited
Loading

find_plugin returns a vector, so the is_ok() check wasn't sufficient to detect the presence of a plugin.

I think this should be sufficient, given the lookup is on the name and version.

It seems to work on both named and unnamed plugins, and specific versions.

Fixes #16

@mefellows mefellows requested a review from rholshausen October 3, 2023 01:20
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited
Loading

Unit Test Results

6 tests  ±0   6 ✔️ ±0   8s ⏱️ +2s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 20a925c. ± Comparison against base commit b1d5576.

♻️ This comment has been updated with latest results.

@mefellows mefellows added the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Oct 3, 2023
@rholshausen rholshausen merged commit 1220875 into main Oct 4, 2023
53 checks passed
@rholshausen rholshausen deleted the fix/issue-16 branch October 4, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rholshausen rholshausen Awaiting requested review from rholshausen

Assignees
No one assigned
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pact-plugin-cli install fails with a non-zero exit code if plugin is already installed
2 participants
@mefellows @rholshausen