Revert "deps: Update ffi library to 0.4.20" #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9097692160Details
💛 - Coveralls |
YOU54F
approved these changes
May 15, 2024
|
Hey @tienvx , Just wanted to show you I got a fix in for the shared lib (building with the latest cross version), and added some content type detection changes in pact-ref. Demoed it in pact-php in the below PR. https://github.com/YOU54F/pact-php/pull/1/files Will need to get changes reviewed in pact-ref but wanted to let you know! |
|
Great news. I can't wait to apply it to pact-php and release another beta for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #611
Because of this pact-foundation/pact-reference#416 (comment)