-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow combining matchers #597
Conversation
Nice! Wow you got onto this feature quickly, I need to get my head into how a consumer might look, ad perhaps try with Pact JS/Go to test it out. Would a review early next week work or is that going to be too late for you? |
A review early next week would be great. I will focus on other things for now. Thanks |
This looks great. With regard to
I was just looking to how this is implemented It looks to support and with regard to naming of ahhh looking further, it doesn't look like I just took a look at the matchers in pact-js and pact-go, to think about how the DSL would look. ie would be want to introduce a |
Yes, it doesn't support. But I assume it will support in the future, and I suggest |
Self-reviewed |
Implemented this feature pact-foundation/pact-reference#405