Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #1325

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ All notable changes to this project will be documented in this file. See [commit
### Features

* drop support for pact web incl. karma examples ([d45f898](https://github.com/pact-foundation/pact-js/commit/d45f898b29a62aa77cecff499a46ce365fd2c79a))
* modify request body inside of verifer ([#873](https://github.com/pact-foundation/pact-js/issues/873)) ([be8ed15](https://github.com/pact-foundation/pact-js/commit/be8ed151c607b69bcf07670df211156887adb29e))
* modify request body inside of verifier ([#873](https://github.com/pact-foundation/pact-js/issues/873)) ([be8ed15](https://github.com/pact-foundation/pact-js/commit/be8ed151c607b69bcf07670df211156887adb29e))


### Fixes and Improvements
Expand Down Expand Up @@ -551,7 +551,7 @@ All notable changes to this project will be documented in this file. See [commit

### Fixes and Improvements

* correct VerfierV3Options so that it doesn't clobber VeriferOptions ([5796fde](https://github.com/pact-foundation/pact-js/commit/5796fdeb96c354316fe9606f0a9a7fc0c3d43532))
* correct VerifierV3Options so that it doesn't clobber VerifierOptions ([5796fde](https://github.com/pact-foundation/pact-js/commit/5796fdeb96c354316fe9606f0a9a7fc0c3d43532))
* You no longer need to import the verifier from /v3, it can be imported directly from @pact-foundation/pact ([c268497](https://github.com/pact-foundation/pact-js/commit/c268497e1fd848d3423d379a2671361ea56c9b53))

## [10.0.0-beta.44](https://github.com/pact-foundation/pact-js/compare/v10.0.0-beta.43...v10.0.0-beta.44) (2021-07-22)
Expand Down Expand Up @@ -872,7 +872,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -931,7 +931,7 @@ different state phases.

### Fixes and Improvements

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -1102,7 +1102,7 @@ different state phases.
### Fixes and Improvements

* broken pact provider test not consistent with types ([29af342](https://github.com/pact-foundation/pact-js/commit/29af34250cdc308a5298553f5ee9bbb9daf182cb))
* correct VerfierV3Options so that it doesn't clobber VeriferOptions ([5796fde](https://github.com/pact-foundation/pact-js/commit/5796fdeb96c354316fe9606f0a9a7fc0c3d43532))
* correct VerifierV3Options so that it doesn't clobber VerifierOptions ([5796fde](https://github.com/pact-foundation/pact-js/commit/5796fdeb96c354316fe9606f0a9a7fc0c3d43532))
* using relative import. fixes problems with intellisense in vscode ([35de1c5](https://github.com/pact-foundation/pact-js/commit/35de1c57d744d5bc747e6af114c8d272b2a8cec4))
* You no longer need to import the verifier from /v3, it can be imported directly from @pact-foundation/pact ([c268497](https://github.com/pact-foundation/pact-js/commit/c268497e1fd848d3423d379a2671361ea56c9b53))

Expand Down Expand Up @@ -1422,7 +1422,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -1481,7 +1481,7 @@ different state phases.

### Fixes and Improvements

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -1785,7 +1785,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -1844,7 +1844,7 @@ different state phases.

### Fixes and Improvements

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -2029,7 +2029,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -2088,7 +2088,7 @@ different state phases.

### Bug Fixes

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -2241,7 +2241,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -2300,7 +2300,7 @@ different state phases.

### Bug Fixes

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -2430,7 +2430,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -2489,7 +2489,7 @@ different state phases.

### Bug Fixes

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -2578,7 +2578,7 @@ different state phases.



* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))

Expand Down Expand Up @@ -2664,7 +2664,7 @@ different state phases.

### Bug Fixes

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
* handle error when pact file cannot be written ([82832a8](https://github.com/pact-foundation/pact-js/commit/82832a81c115d06ef2d9c1fadd18c54f6f629e59))
* throw an exception when a request is configured but no interaction defined ([b317da7](https://github.com/pact-foundation/pact-js/commit/b317da79f28dce45102a55bcdcbc415d3fbdb9ab))
Expand Down Expand Up @@ -2730,7 +2730,7 @@ different state phases.

### Features

* add some tests around the conusmer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* add some tests around the consumer DSL matchers ([e6a153f](https://github.com/pact-foundation/pact-js/commit/e6a153fd62d48644b97018d69e5f23d1710e510f))
* handle XML matching with different types of child elements ([2143ca4](https://github.com/pact-foundation/pact-js/commit/2143ca4c968969e1c6218dd8e538097733ccfa56))
* implemented consumer DSL URL matcher ([f27a444](https://github.com/pact-foundation/pact-js/commit/f27a44409aed3ece1adbab6af9e853b7684c101c))
* package.json & package-lock.json to reduce vulnerabilities ([0bb8512](https://github.com/pact-foundation/pact-js/commit/0bb851255c0f08d25fd935e5bd164ce99063a9ae))
Expand Down Expand Up @@ -2811,7 +2811,7 @@ different state phases.

### Bug Fixes

* accidentially commited development paths in cargo manefest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* accidentally committed development paths in cargo manifest ([03cc16f](https://github.com/pact-foundation/pact-js/commit/03cc16f71d5f6a6cd646cdb6cf5421a134cb159e))
* comments and accidental package ([efe2f4e](https://github.com/pact-foundation/pact-js/commit/efe2f4eef3f05e8ea4a067403c69b75e3236aea9))
* dir file location error ([86ab843](https://github.com/pact-foundation/pact-js/commit/86ab8433a5c4400330c71b6e9a64cfde49c75461))
* format the error messages in a better way ([0a15772](https://github.com/pact-foundation/pact-js/commit/0a15772a710d3d159648672470084a1c99b45cc8))
Expand Down
18 changes: 9 additions & 9 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@
## Breaking Changes

All CLI/API functionality provided by the Pact CLI tools (ruby based) now migrated to

* Repo

* https://github.com/pact-foundation/pact-js-cli/

* NPM Package

* https://www.npmjs.com/package/@pact-foundation/pact-cli

* imports
* `@pact-foundation/pact-core` imports will now become `@pact-foundation/pact-cli` for programatic usage of the CLI tools

* `@pact-foundation/pact-core` imports will now become `@pact-foundation/pact-cli` for programmatic usage of the CLI tools

* npx usage

* `npx --package=@pact-foundation/[email protected] -c pact-broker`

# 11.x.x -> 12.x.x
Expand Down Expand Up @@ -53,7 +53,7 @@ Removed the default export for v3 in the root package in preparation for a relea
* add binary content support to messages via `WithBinaryContent`
* add text content support to messages via `WithTextContent`
* Remove all Ruby dependencies in DSLs
* `pactfileWriteMode` still supports the same options, however the behaviour of `overwrite` is such now that it will overwrite the pact file _per test_, not pact run of Pact. This is because there is no longer a single long running mock server as per previous versions. Set to `merge` or leave blank for a sensible default.
* `pactfileWriteMode` still supports the same options, however the behaviour of `overwrite` is such now that it will overwrite the pact file _per test_, not pact run of Pact. This is because there is no longer a single long running mock server as per previous versions. Set to `merge` or leave blank for a sensible default.
* As per the change to `pactfileWriteMode` this also means pact files should be cleared out prior to each test, to avoid extraneous interactions in a pact file.
* Array matcher currently doesn't work on query strings (see https://github.com/pact-foundation/pact-reference/issues/205). However, an array with matchers is supported (see jest spec)
* the `mockService` property on the `Pact` class is no longer an actual `MockService`, but supports the `baseUrl` property.
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ npm i -S @pact-foundation/pact@latest
# 🚀 now write some tests!
```

Looking for the previous [stable 9.x.x release](https://github.com/pact-foundation/pact-js/tree/9.x.x)?
Looking for the previous [stable 9.x.x release](https://github.com/pact-foundation/pact-js/tree/9.x.x)?

### Requirements

Expand Down Expand Up @@ -136,7 +136,7 @@ const provider = new PactV3({
provider: 'MyProvider',
});

// API Client that will fetch dogs from the Dog API
// API Client that will fetch dogs from the Dog API
// This is the target of our Pact test
public getMeDogs = (from: string): AxiosPromise => {
return axios.request({
Expand Down Expand Up @@ -174,8 +174,8 @@ describe('GET /dogs', () => {
return provider.executeTest((mockserver) => {
// Act: test our API client behaves correctly
//
// Note we configure the DogService API client dynamically to
// point to the mock service Pact created for us, instead of
// Note we configure the DogService API client dynamically to
// point to the mock service Pact created for us, instead of
// the real one
dogService = new DogService(mockserver.url);
const response = await dogService.getMeDogs('today')
Expand Down
2 changes: 1 addition & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ We've moved to GitHub Actions for releases.

## How a release works

Releases trigger when the repository recieves the custom repository_dispatch event
Releases trigger when the repository receives the custom repository_dispatch event
`release-triggered`.

This triggers the `publish.yml` workflow, which in turn
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e/test/consumer.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe('Pact', () => {
});
});

describe('when a call to the Animal Service is made to retreive a single animal by ID', () => {
describe('when a call to the Animal Service is made to retrieve a single animal by ID', () => {
describe('and there is an animal in the DB with ID 1', () => {
before(() =>
provider.addInteraction({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const accounts = [];

const accountRepository = {
save: (account) => {
// This similates a save to the DB where the IDs get allocated
// This simulates a save to the DB where the IDs get allocated
let id = Math.floor(Math.random() * Math.floor(100000));
let accountNumber = Math.floor(Math.random() * Math.floor(100000));
let version = Math.floor(Math.random() * Math.floor(10));
Expand Down
2 changes: 1 addition & 1 deletion src/dsl/apolloGraphql.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('ApolloGraphQLInteraction', () => {
});

describe('#withOperation', () => {
describe('when no operationNaame is presented', () => {
describe('when no operationName is presented', () => {
it('adds a null operationName property to the payload', () => {
interaction.uponReceiving('a request');
interaction.withRequest({
Expand Down
Loading
Loading