Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pact ffi on release workflow #479

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jan 31, 2024

Aim:- Provide a CI workflow, that can be triggered on release of the Pact FFI library.

Relates to pact-foundation/pact-reference#375 , specifically Trigger dependant client libraries workflows to raise PR's

This change borrows from the existing update workflow on release of the pact-ruby-standalone.

Places to change (outside this repo)

  1. Release point in Pact-reference project
    1. https://github.com/pact-foundation/pact-reference/blob/fc33ad23e78698ecf1fb55eedb7dc228f96def17/.github/workflows/release.yml#L74-L81
  2. Example Release
    1. https://github.com/pact-foundation/pact-reference/releases/tag/libpact_ffi-v0.4.14

Points to note

Our ci workflow for verification .github/workflows/build-and-test.yml is not triggered by updates. See related issue and workarounds

Note: - the above issue is long-standing from the existing updates, at least from my quick scan of the test runs, I couldn't see triggered when the ruby core was updated, bar those triggered manually from the UI against the branch

There are a couple of workarounds that are probably feasible. first one probably preferred at the moment as we get a visual cue somewhere outside of the actions/email notifications. The triggering repo (pact-reference) won't get a notification back regarding the failing status of a build in pact-js where it was triggered by a bot or a human

  • close PR and reopen from UI
  • have the update workflow that is initially triggered, run the tests as part of its workflow

@YOU54F YOU54F merged commit 4197bdf into pact-foundation:master Jan 31, 2024
19 of 21 checks passed
@YOU54F YOU54F deleted the ci/ffi_upgrade branch June 26, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant