-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/test x plat #351
Ci/test x plat #351
Changes from 6 commits
9738a2b
83a6629
7784309
aad2dd1
27d01f8
fc7f790
5b3fa4d
954b35e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
test: &TEST | ||
test_script: make test | ||
|
||
linux_arm64_task: | ||
env: | ||
SKIP_PLUGIN_AVRO: "true" | ||
matrix: | ||
- VERSION: 1.19 | ||
- VERSION: 1.20 | ||
- VERSION: 1.21 | ||
# name: Tests (Go $VERSION) | ||
arm_container: | ||
image: golang:$VERSION | ||
<<: *TEST | ||
|
||
macos_arm64_task: | ||
macos_instance: | ||
image: ghcr.io/cirruslabs/macos-ventura-base:latest | ||
golang_pre_req_script: brew install go@$VERSION | ||
cirrus_cli_pre_req_script: chmod +x scripts/*.sh | ||
plugin_protobuf_pre_req_script: brew install protobuf | ||
# plugin_avro_pre_req_script: brew install openjdk@17 && java --version | ||
env: | ||
PATH: "/opt/homebrew/opt/go@$VERSION/bin:$PATH" # Needed golang | ||
# PATH: "/opt/homebrew/opt/openjdk@17/bin:$PATH" # Needed for Avro Plugin | ||
SKIP_PLUGIN_AVRO: "true" | ||
matrix: | ||
- VERSION: 1.19 | ||
- VERSION: 1.20 | ||
- VERSION: 1.21 | ||
<<: *TEST |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,3 +57,25 @@ jobs: | |
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
parallel-finished: true | ||
|
||
test-other-os: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason why you didn't just merge this into the This doesn't run the examples, but just the tests from what I can see (which is probably fine, if we ever build the compatibility suite for proper feature regression testing). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thought
not sure how yaks we would need to end up shaving to get this working, so thought I would just create a seperate job to check whats needed for these non linux os's, and then could roll everything back together intro one job There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool, I thought so. It's better than where we were, but just wanted to clarify. |
||
strategy: | ||
matrix: | ||
go-version: [ # https://endoflife.date/go | ||
1.19.x, | ||
1.20.x, | ||
1.21.x | ||
] | ||
os: [macos-latest,windows-latest] | ||
fail-fast: false | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Install Go | ||
uses: actions/setup-go@v4 | ||
with: | ||
go-version: ${{ matrix.go-version }} | ||
- run: make test | ||
env: | ||
SKIP_PLUGIN_AVRO: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
{ | ||
"consumer": { | ||
"name": "AvroConsumer" | ||
}, | ||
"interactions": [ | ||
{ | ||
"description": "A request to do get some Avro stuff", | ||
"pending": false, | ||
"pluginConfiguration": { | ||
"avro": { | ||
"record": "User", | ||
"schemaKey": "1184dbf3292cee8bc7390762dd15fc52" | ||
} | ||
}, | ||
"request": { | ||
"method": "GET", | ||
"path": "/avro" | ||
}, | ||
"response": { | ||
"body": { | ||
"content": "AghtYXR0", | ||
"contentType": "avro/binary;record=User", | ||
"contentTypeHint": "BINARY", | ||
"encoded": "base64" | ||
}, | ||
"headers": { | ||
"content-type": [ | ||
"avro/binary" | ||
] | ||
}, | ||
"matchingRules": { | ||
"body": { | ||
"$.id": { | ||
"combine": "AND", | ||
"matchers": [ | ||
{ | ||
"match": "number" | ||
} | ||
] | ||
}, | ||
"$.username": { | ||
"combine": "AND", | ||
"matchers": [ | ||
{ | ||
"match": "notEmpty" | ||
} | ||
] | ||
} | ||
} | ||
}, | ||
"status": 200 | ||
}, | ||
"transport": "http", | ||
"type": "Synchronous/HTTP" | ||
} | ||
], | ||
"metadata": { | ||
"pactRust": { | ||
"ffi": "0.4.5", | ||
"mockserver": "1.1.1", | ||
"models": "1.1.2" | ||
}, | ||
"pactSpecification": { | ||
"version": "4.0" | ||
}, | ||
"plugins": [ | ||
{ | ||
"configuration": { | ||
"1184dbf3292cee8bc7390762dd15fc52": { | ||
"avroSchema": "{\"type\":\"record\",\"name\":\"User\",\"namespace\":\"io.pact\",\"fields\":[{\"name\":\"id\",\"type\":\"long\"},{\"name\":\"username\",\"type\":\"string\"}]}" | ||
} | ||
}, | ||
"name": "avro", | ||
"version": "0.0.4" | ||
} | ||
] | ||
}, | ||
"provider": { | ||
"name": "AvroProvider" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this (and related references) was put in the "do it later" basket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah avro was failing, needs java plus other yaks.