Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set svc annotations #88

Merged

Conversation

shanehull
Copy link
Contributor

Adds the ability to set additional annotations on the Service resource.

@ChrisJBurns
Copy link
Contributor

Thanks @shanehull I'll try and give this a look so we can get it merged in. I may have to add CI tests into the Actions flow before we do merge this PR though just so we have as much assurance as possible.

@shanehull
Copy link
Contributor Author

@ChrisJBurns let me know if there's anything we can do to get this merged. Currently we're blocked on using the chart, as we need annotations on the Service resource to be able to expose it.

@ChrisJBurns
Copy link
Contributor

@shanehull Yep apologies, just had a chance to go through my unreads. Have approved and run pipeline, and seems to be ok, however are you able to sign the commit?

@shanehull shanehull force-pushed the feat/service-annotations branch from f0b5f03 to 28f6343 Compare September 5, 2024 21:13
@shanehull
Copy link
Contributor Author

Done @ChrisJBurns.

@ChrisJBurns
Copy link
Contributor

@shanehull I don't think the commit itself has been signed, you've added a signature to the commit message but the commit itself isn't signed with a key for more info: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@shanehull shanehull force-pushed the feat/service-annotations branch from 28f6343 to 461e4bc Compare September 5, 2024 23:35
@shanehull shanehull force-pushed the feat/service-annotations branch from 461e4bc to 57fe8c7 Compare September 5, 2024 23:37
@shanehull
Copy link
Contributor Author

Sorry @ChrisJBurns, should be verified now.

@ChrisJBurns ChrisJBurns merged commit 6f2e4e1 into pact-foundation:master Sep 6, 2024
3 checks passed
@ChrisJBurns
Copy link
Contributor

Thanks @shanehull , merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants