Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow update extra file without manually deletion #51

Merged
merged 1 commit into from
May 16, 2024

Conversation

tienvx
Copy link
Collaborator

@tienvx tienvx commented May 16, 2024

There is a regression on 2.0 compared to 1.0, that is:

When update extra file to new version, this warning is always displayed:

Extra file some-name has been locally overriden in path/to/file. To reset it, delete and reinstall.

It's because of the wrong condition. I reverted to the old condition in https://github.com/pact-foundation/composer-downloads-plugin/blob/v1.0.0/src/SubpackageInstaller.php

@tienvx
Copy link
Collaborator Author

tienvx commented May 16, 2024

Self-reviewed

@tienvx tienvx merged commit 0f9fdec into main May 16, 2024
32 checks passed
@tienvx tienvx deleted the allow-update-without-manual-deletion branch May 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant