Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(2.0): Add FileInstaller #40

Merged
merged 1 commit into from
Apr 19, 2024
Merged

refactor(2.0): Add FileInstaller #40

merged 1 commit into from
Apr 19, 2024

Conversation

tienvx
Copy link
Collaborator

@tienvx tienvx commented Apr 18, 2024

  • First, FileInstaller download the extra file
  • If the downloaded file is not valid (hashes doesn't match), then throw an error
  • If the downloaded file is valid, then it move (normal file)/extract (gzip file) into a temporary directory
  • Then the installer will move the only file inside temporary directory into expected path
  • Then the installer will remove temporary directory
  • Then the installer will make file executable (if needed)
  • Then it mark the extra file as installed in the repository

@tienvx tienvx requested a review from JP-Ellis April 18, 2024 12:20
@tienvx tienvx merged commit ea4f80f into main Apr 19, 2024
23 checks passed
@tienvx tienvx deleted the file-installer branch April 19, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @JP-Ellis