Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(2.0): Add ExtraDownload factories #35

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

tienvx
Copy link
Collaborator

@tienvx tienvx commented Apr 16, 2024

  • ExtraArchive and ExtraDownload are quite similar classes, with 1 extra constructor's parameter.
  • That's why factories for them are quite similar: ExtraArchiveFactory, ExtraDownloadFactory

@tienvx tienvx requested a review from JP-Ellis April 16, 2024 16:36
@tienvx tienvx merged commit e785c2e into main Apr 17, 2024
17 checks passed
@tienvx tienvx deleted the extra-download-factories branch April 17, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants