Merge pull request #48 from pact-foundation/use-eol-constant

test: Use PHP_EOL constant
pact-foundation · Apr 25, 2024 · 8e62ac9 · 8e62ac9
2 parents dacee30 + c8b3565
commit 8e62ac9
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/tests/Integration/CommandTestCase.php b/tests/Integration/CommandTestCase.php
@@ -244,11 +244,11 @@ protected function getExecutableFilesFromLibrary(): array
     {
         return [
             'vendor/test/library/files/php/hello-php' => 'Hello from php file!',
-            'vendor/test/library/files/ruby/hello-ruby' => 'Hello from ruby file!'.$this->eol(),
-            'vendor/test/library/files/mix/bin/hello-python' => 'Hello from python file!'.$this->eol(),
+            'vendor/test/library/files/ruby/hello-ruby' => 'Hello from ruby file!'.\PHP_EOL,
+            'vendor/test/library/files/mix/bin/hello-python' => 'Hello from python file!'.\PHP_EOL,
             'vendor/bin/hello-php' => 'Hello from php file!',
-            'vendor/bin/hello-ruby' => 'Hello from ruby file!'.$this->eol(),
-            'vendor/bin/hello-python' => 'Hello from python file!'.$this->eol(),
+            'vendor/bin/hello-ruby' => 'Hello from ruby file!'.\PHP_EOL,
+            'vendor/bin/hello-python' => 'Hello from python file!'.\PHP_EOL,
         ];
     }
 
@@ -403,9 +403,4 @@ protected static function getLibraryPath(): string
     {
         return realpath(self::getFixturesPath().'/library');
     }
-
-    protected function eol(): string
-    {
-        return \PHP_OS_FAMILY === 'Windows' ? "\r\n" : "\n";
-    }
 }