add: webstorm-bin
#6751
Open
add: webstorm-bin
#6751
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Package Add
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Elsie19
requested changes
Dec 12, 2024
|
It's ready to review, I've fixed and follow your suggestions @Elsie19. |
Elsie19
requested changes
Dec 12, 2024
Comment on lines
+15
to
+18
| cd "${srcdir}/WebStorm-243.22562.112" || { | ||
| echo "Directory not found" | ||
| exit 1 | ||
| } |
There was a problem hiding this comment.
This should never ever fail and if it does there are bigger issues than that. Assume it works and remove the guard.
There was a problem hiding this comment.
It actually works, but it couldn't work in pre-commit side
There was a problem hiding this comment.
Remove the guards please. I will deal with precommit.
There was a problem hiding this comment.
Remove the guards please. I will deal with precommit.
Alright, I'll do it after exams tomorrow.
Comment on lines
+25
to
+28
| if [ ! -e "$item" ]; then | ||
| echo "Error: $item not found" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Assume everything works. It always should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WebStorm as available for free (non-commercial usages) and part of requests I made based on #6744. The versions are 2024.3.1.