Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pacstall-gui-git): Change settings.sh install location #4684

Merged
merged 6 commits into from
Oct 23, 2023
Merged

fix(pacstall-gui-git): Change settings.sh install location #4684

merged 6 commits into from
Oct 23, 2023

Conversation

cat-master21
Copy link
Collaborator

In my script, the location of settings.sh has changed so I have updated this to reflect that.

@github-actions github-actions bot added the Update Pacscript Updates to the pacscript itself label Oct 20, 2023
@cat-master21 cat-master21 requested a review from Elsie19 October 20, 2023 14:28
Elsie19
Elsie19 requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually where should we put these files, because we shouldn't be packing a Deb with hardcoded paths to home directories.

@cat-master21
Copy link
Collaborator Author

cat-master21 commented Oct 20, 2023 •
edited
Loading

In that case @Elsie19 I can just move it to the user's home directory. I will do it later. It is okay my program automatically regenerates the file in case it is missing.

@cat-master21 cat-master21 requested a review from Elsie19 October 21, 2023 01:18
@cat-master21 cat-master21 requested a review from Elsie19 October 21, 2023 02:43
Elsie19
Elsie19 reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR do anything? It seems to just be removing the creation of "${pkgdir}/usr/lib/pacstall-gui", and removing settings.shentirely.

@cat-master21
Copy link
Collaborator Author

Yes, as in the script, settings.sh's location got moved to ~/.config/pacstall-gui but is not really needed because the script generates it if it is missing but it is not needed at /usr/lib/pacstall-gui anymore @Elsie19.

@Elsie19 Elsie19 merged commit 7df9c1f into pacstall:master Oct 23, 2023
20 checks passed
@cat-master21 cat-master21 deleted the gui branch October 23, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie19 Elsie19 Elsie19 approved these changes

Assignees

@cat-master21 cat-master21

Labels
Update Pacscript Updates to the pacscript itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cat-master21 @Elsie19