-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upd(obs-backgroundremoval): 1.1.3
-> 1.1.6
#4576
Conversation
28dc54b
to
d4023be
Compare
All the systems are included in the incompatible field. I didn't change the incompatible field and I don't know why every system is incompatible. |
Have you tested on supposed incompatible systems? |
I think we need to add PPA OBS distribution to pacstall repository first. |
I met some build dependencies missing in the distros which are in the incompatible field. PS: debian has no ppa support though? |
I will test these systems again |
Version 1.1.6 builds fine in jammy and is even compatible with obs 27, which was unexpected |
Focal fails with
It has cmake 3.16.3 which is supposed to be compatible since https://github.com/royshil/obs-backgroundremoval/pull/250/files PS: cmake-deb pacscript (3.25.1) is not installable on focal due to missing dependencies PPS: if I install cmake with pip (3.27.5), I get these errors:
|
I was able to compile in bullseye by changing qt6-base-dev to qtbase5-dev and adding -DQT_VERSION=5 to cmake arguments. But it fails at loading in obs with:
|
c3909cf
to
53cce73
Compare
I don't think our plugin can be built with CMake 3.16. |
Should line 1 of CMakeList be updated? https://github.com/royshil/obs-backgroundremoval/blob/main/CMakeLists.txt#L1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umireon Merge in from master for the checks not to fail
Error: The head commit for this pull_request event is not ahead of the base commit.
Ok it works, but do we want to try getting it working on all these distros or no? |
I don't know why the uninstalling test fails. Does this test need to be passed? |
It works on Ubuntu jammy LTS and more recent, Debian stable, testing, and sid. I consider it’s good enough.
This is only a CI issue due to the cmake-deb pacdep. We should be good to merge. |
1.1.3
-> 1.1.6
Co-authored-by: Elsie <[email protected]>
No description provided.